Commit 7f556567 authored by Hugh Dickins's avatar Hugh Dickins Committed by Linus Torvalds

tmpfs: fix regression hang in fallocate undo

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page.  index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away.  Big thank you to xfstests generic/269 which demonstrates this.

Fixes: b9b4bb26 ("tmpfs: don't undo fallocate past its last page")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHugh Dickins <hughd@google.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 617a8d6b
...@@ -2225,9 +2225,11 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset, ...@@ -2225,9 +2225,11 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset,
error = shmem_getpage(inode, index, &page, SGP_FALLOC); error = shmem_getpage(inode, index, &page, SGP_FALLOC);
if (error) { if (error) {
/* Remove the !PageUptodate pages we added */ /* Remove the !PageUptodate pages we added */
if (index > start) {
shmem_undo_range(inode, shmem_undo_range(inode,
(loff_t)start << PAGE_SHIFT, (loff_t)start << PAGE_SHIFT,
((loff_t)index << PAGE_SHIFT) - 1, true); ((loff_t)index << PAGE_SHIFT) - 1, true);
}
goto undone; goto undone;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment