Commit 80198980 authored by Colin Ian King's avatar Colin Ian King Committed by Greg Kroah-Hartman

PCI: rockchip: Fix rockchip_pcie_ep_assert_intx() bitwise operations

[ Upstream commit c577f4a5 ]

Currently the bitwise operations on the u16 variable 'status' with
the setting ROCKCHIP_PCIE_EP_CMD_STATUS_IS are incorrect because
ROCKCHIP_PCIE_EP_CMD_STATUS_IS is 1UL<<19 which is wider than the
u16 variable.

Fix this by making status a u32.

Fixes: cf590b07 ("PCI: rockchip: Add EP driver for Rockchip PCIe controller")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Acked-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5d918cd2
...@@ -350,7 +350,7 @@ static void rockchip_pcie_ep_assert_intx(struct rockchip_pcie_ep *ep, u8 fn, ...@@ -350,7 +350,7 @@ static void rockchip_pcie_ep_assert_intx(struct rockchip_pcie_ep *ep, u8 fn,
struct rockchip_pcie *rockchip = &ep->rockchip; struct rockchip_pcie *rockchip = &ep->rockchip;
u32 r = ep->max_regions - 1; u32 r = ep->max_regions - 1;
u32 offset; u32 offset;
u16 status; u32 status;
u8 msg_code; u8 msg_code;
if (unlikely(ep->irq_pci_addr != ROCKCHIP_PCIE_EP_PCI_LEGACY_IRQ_ADDR || if (unlikely(ep->irq_pci_addr != ROCKCHIP_PCIE_EP_PCI_LEGACY_IRQ_ADDR ||
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment