Commit 80491eb9 authored by Linus Torvalds's avatar Linus Torvalds

Revert unintentional "volatile" changes in ipc/msg.c

Commit 5a06a363 ("[PATCH] ipc/msg.c:
clean up coding style") breaks fakeroot on Alpha (variously hangs or
oopses), according to a report by Falk Hueffner.

The fact that the code seems to rely on compiler access ordering through
the use of "volatile" is a pretty certain sign that the code has locking
problems, and we should fix those properly and then remove the whole
"volatile" entirely.

But in the meantime, the movement of "volatile" was unintentional, and
should be reverted.

Cc: Falk Hueffner <falk@debian.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent ddac0d39
...@@ -52,7 +52,7 @@ struct msg_receiver { ...@@ -52,7 +52,7 @@ struct msg_receiver {
long r_msgtype; long r_msgtype;
long r_maxsize; long r_maxsize;
volatile struct msg_msg *r_msg; struct msg_msg *volatile r_msg;
}; };
/* one msg_sender for each sleeping sender */ /* one msg_sender for each sleeping sender */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment