Commit 81dae1f3 authored by Marek Vasut's avatar Marek Vasut Committed by Robert Foss

drm/bridge: lvds-codec: Fix error checking of drm_of_lvds_get_data_mapping()

The drm_of_lvds_get_data_mapping() returns either negative value on
error or MEDIA_BUS_FMT_* otherwise. The check for 'ret' would also
catch the positive case of MEDIA_BUS_FMT_* and lead to probe failure
every time 'data-mapping' DT property is specified.

Fixes: 7c4dd0a2 ("drm: of: Add drm_of_lvds_get_data_mapping")
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
To: dri-devel@lists.freedesktop.org
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220801125419.167562-1-marex@denx.de
parent d688f6b5
...@@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev) ...@@ -180,7 +180,7 @@ static int lvds_codec_probe(struct platform_device *pdev)
of_node_put(bus_node); of_node_put(bus_node);
if (ret == -ENODEV) { if (ret == -ENODEV) {
dev_warn(dev, "missing 'data-mapping' DT property\n"); dev_warn(dev, "missing 'data-mapping' DT property\n");
} else if (ret) { } else if (ret < 0) {
dev_err(dev, "invalid 'data-mapping' DT property\n"); dev_err(dev, "invalid 'data-mapping' DT property\n");
return ret; return ret;
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment