Commit 82b8ba29 authored by Alison Schofield's avatar Alison Schofield Committed by Dan Williams

cxl/mbox: Remove dependency on cxl_mem_command for a debug msg

In preparation for removing access to struct cxl_mem_command,
change this debug message to use cxl_mbox_cmd fields instead.
Retrieve the pretty command name from cxl_mbox_cmd using a new
opcode to command name helper.
Signed-off-by: default avatarAlison Schofield <alison.schofield@intel.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarDan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/r/57265751d336a6e95f5ca31a9c77189408b05742.1648687552.git.alison.schofield@intel.comSigned-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 9ae016ae
...@@ -127,6 +127,17 @@ static struct cxl_mem_command *cxl_mem_find_command(u16 opcode) ...@@ -127,6 +127,17 @@ static struct cxl_mem_command *cxl_mem_find_command(u16 opcode)
return NULL; return NULL;
} }
static const char *cxl_mem_opcode_to_name(u16 opcode)
{
struct cxl_mem_command *c;
c = cxl_mem_find_command(opcode);
if (!c)
return NULL;
return cxl_command_names[c->info.id].name;
}
/** /**
* cxl_mbox_send_cmd() - Send a mailbox command to a device. * cxl_mbox_send_cmd() - Send a mailbox command to a device.
* @cxlds: The device data for the operation * @cxlds: The device data for the operation
...@@ -452,9 +463,9 @@ static int handle_mailbox_cmd_from_user(struct cxl_dev_state *cxlds, ...@@ -452,9 +463,9 @@ static int handle_mailbox_cmd_from_user(struct cxl_dev_state *cxlds,
dev_dbg(dev, dev_dbg(dev,
"Submitting %s command for user\n" "Submitting %s command for user\n"
"\topcode: %x\n" "\topcode: %x\n"
"\tsize: %ub\n", "\tsize: %zx\n",
cxl_command_names[cmd->info.id].name, mbox_cmd.opcode, cxl_mem_opcode_to_name(mbox_cmd.opcode),
cmd->info.size_in); mbox_cmd.opcode, mbox_cmd.size_in);
rc = cxlds->mbox_send(cxlds, &mbox_cmd); rc = cxlds->mbox_send(cxlds, &mbox_cmd);
if (rc) if (rc)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment