Commit 855e2f60 authored by Johannes Berg's avatar Johannes Berg

wifi: iwlwifi: pcie: remove redundant argument

The iwl_pcie_alloc_fw_monitor_block() function has an argument
that's only ever hard-coded to 11, remove it and hard-code the
value into the function itself with a comment.
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230613155501.737c153e8259.Ibe6250ca812cfa2f00ac47e5e0d1595c6b9b4875@changeidSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 583c58e3
...@@ -163,7 +163,7 @@ static void iwl_pcie_free_fw_monitor(struct iwl_trans *trans) ...@@ -163,7 +163,7 @@ static void iwl_pcie_free_fw_monitor(struct iwl_trans *trans)
} }
static void iwl_pcie_alloc_fw_monitor_block(struct iwl_trans *trans, static void iwl_pcie_alloc_fw_monitor_block(struct iwl_trans *trans,
u8 max_power, u8 min_power) u8 max_power)
{ {
struct iwl_dram_data *fw_mon = &trans->dbg.fw_mon; struct iwl_dram_data *fw_mon = &trans->dbg.fw_mon;
void *block = NULL; void *block = NULL;
...@@ -176,7 +176,8 @@ static void iwl_pcie_alloc_fw_monitor_block(struct iwl_trans *trans, ...@@ -176,7 +176,8 @@ static void iwl_pcie_alloc_fw_monitor_block(struct iwl_trans *trans,
return; return;
} }
for (power = max_power; power >= min_power; power--) { /* need at least 2 KiB, so stop at 11 */
for (power = max_power; power >= 11; power--) {
size = BIT(power); size = BIT(power);
block = dma_alloc_coherent(trans->dev, size, &physical, block = dma_alloc_coherent(trans->dev, size, &physical,
GFP_KERNEL | __GFP_NOWARN); GFP_KERNEL | __GFP_NOWARN);
...@@ -217,7 +218,7 @@ void iwl_pcie_alloc_fw_monitor(struct iwl_trans *trans, u8 max_power) ...@@ -217,7 +218,7 @@ void iwl_pcie_alloc_fw_monitor(struct iwl_trans *trans, u8 max_power)
max_power)) max_power))
return; return;
iwl_pcie_alloc_fw_monitor_block(trans, max_power, 11); iwl_pcie_alloc_fw_monitor_block(trans, max_power);
} }
static u32 iwl_trans_pcie_read_shr(struct iwl_trans *trans, u32 reg) static u32 iwl_trans_pcie_read_shr(struct iwl_trans *trans, u32 reg)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment