Commit 86e666df authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Linus Walleij

dt-bindings: pinctrl: rt2880: properly redo bindings

When this bindings where applied there weren't already
reviewed and some old hacks was being used to properly
pass the schemas checks. This commits fix them up:
 - Instead of using 'if-then' clause use '-pins$'.
 - 'groups' and 'function' are included inside a new
   '^(.*-)?pinmux$' node.
 - compatible string is not an 'enum' but a 'const'.
 - 'pinctrl-0' and 'pinctrl-names' removed since they are
    used in consumer nodes.
Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20201213161721.6514-2-sergio.paracuellos@gmail.comSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 502045d9
...@@ -15,29 +15,17 @@ description: ...@@ -15,29 +15,17 @@ description:
properties: properties:
compatible: compatible:
enum: const: ralink,rt2880-pinmux
- ralink,rt2880-pinmux
pinctrl-0:
description:
A phandle to the node containing the subnodes containing default
configurations. This is for pinctrl hogs.
pinctrl-names:
description:
A pinctrl state named "default" can be defined.
const: default
required:
- compatible
patternProperties: patternProperties:
'[a-z0-9_-]+': '-pins$':
if: type: object
patternProperties:
'^(.*-)?pinmux$':
type: object type: object
description: node for pinctrl. description: node for pinctrl.
$ref: "pinmux-node.yaml" $ref: pinmux-node.yaml#
then:
properties: properties:
groups: groups:
description: Name of the pin group to use for the functions. description: Name of the pin group to use for the functions.
...@@ -48,6 +36,17 @@ patternProperties: ...@@ -48,6 +36,17 @@ patternProperties:
enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2, enum: [gpio, i2c, spi, uart1, uart2, uart3, rgmii1, rgmii2,
mdio, nand1, nand2, sdhci] mdio, nand1, nand2, sdhci]
required:
- groups
- function
additionalProperties: false
additionalProperties: false
required:
- compatible
additionalProperties: false additionalProperties: false
examples: examples:
...@@ -55,14 +54,9 @@ examples: ...@@ -55,14 +54,9 @@ examples:
- | - |
pinctrl { pinctrl {
compatible = "ralink,rt2880-pinmux"; compatible = "ralink,rt2880-pinmux";
pinctrl-names = "default";
pinctrl-0 = <&state_default>;
state_default: pinctrl0 {
};
i2c_pins: i2c0 { i2c_pins: i2c0-pins {
i2c0 { pinmux {
groups = "i2c"; groups = "i2c";
function = "i2c"; function = "i2c";
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment