Commit 87f9a031 authored by Eryu Guan's avatar Eryu Guan Committed by Theodore Ts'o

ext4: iterate over buffer heads correctly in move_extent_per_page()

In commit bcff2488 ("ext4: don't read blocks from disk after extents
being swapped") bh is not updated correctly in the for loop and wrong
data has been written to disk. generic/324 catches this on sub-page
block size ext4.

Fixes: bcff2488 ("ext4: don't read blocks from disk after extentsbeing swapped")
Signed-off-by: default avatarEryu Guan <guaneryu@gmail.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
parent f96c450d
...@@ -390,6 +390,7 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, ...@@ -390,6 +390,7 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode,
*err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0); *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0);
if (*err < 0) if (*err < 0)
break; break;
bh = bh->b_this_page;
} }
if (!*err) if (!*err)
*err = block_commit_write(pagep[0], from, from + replaced_size); *err = block_commit_write(pagep[0], from, from + replaced_size);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment