Commit 88eddb0c authored by Benjamin Poirier's avatar Benjamin Poirier Committed by Greg Kroah-Hartman

staging: qlge: Update TODO

Update TODO file to reflect the changes that have been done:
* multiple functions were renamed to have the "qlge_" prefix in commit
  f8c047be ("staging: qlge: use qlge_* prefix to avoid namespace
  clashes with other qlogic drivers")
* a redundant memset() was removed in commit 953b9400 ("staging: qlge:
  Initialize devlink health dump framework")
* the loop boundary in ql(ge)_alloc_rx_buffers() was updated in commit
  e4c911a7 ("staging: qlge: Remove rx_ring.type")
* pci_enable_msi() was replaced in commit 4eab532d ("staging:
  qlge/qlge_main.c: Replace depracated MSI API.")
* pci_dma_* were replaced in commit e955a071 ("staging: qlge: replace
  deprecated apis pci_dma_*")
* the while loops were rewritten in commit 41e1bf81 ("Staging: qlge:
  Rewrite two while loops as simple for loops")
* indentation was fixed in commit 0eb79fd1 ("staging: qlge: cleanup
  indent in qlge_main.c")

I also slipped in one new TODO item, naughty me!
Signed-off-by: default avatarBenjamin Poirier <benjamin.poirier@gmail.com>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20231020124457.312449-2-benjamin.poirier@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5fe030e3
* commit 7c734359d350 ("qlge: Size RX buffers based on MTU.", v2.6.33-rc1) * commit 7c734359d350 ("qlge: Size RX buffers based on MTU.", v2.6.33-rc1)
introduced dead code in the receive routines, which should be rewritten introduced dead code in the receive routines, which should be rewritten
anyways by the admission of the author himself, see the comment above anyways by the admission of the author himself, see the comment above
ql_build_rx_skb(). That function is now used exclusively to handle packets qlge_build_rx_skb(). That function is now used exclusively to handle packets
that underwent header splitting but it still contains code to handle non that underwent header splitting but it still contains code to handle non
split cases. split cases.
* truesize accounting is incorrect (ex: a 9000B frame has skb->truesize 10280 * truesize accounting is incorrect (ex: a 9000B frame has skb->truesize 10280
...@@ -17,17 +17,12 @@ ...@@ -17,17 +17,12 @@
* the flow control implementation in firmware is buggy (sends a flood of pause * the flow control implementation in firmware is buggy (sends a flood of pause
frames, resets the link, device and driver buffer queues become frames, resets the link, device and driver buffer queues become
desynchronized), disable it by default desynchronized), disable it by default
* some structures are initialized redundantly (ex. memset 0 after
alloc_etherdev())
* the driver has a habit of using runtime checks where compile time checks are * the driver has a habit of using runtime checks where compile time checks are
possible (ex. ql_free_rx_buffers(), ql_alloc_rx_buffers()) possible (ex. qlge_free_rx_buffers())
* reorder struct members to avoid holes if it doesn't impact performance * reorder struct members to avoid holes if it doesn't impact performance
* avoid legacy/deprecated apis (ex. replace pci_dma_*, replace pci_enable_msi, * use better-suited apis (ex. use pci_iomap() instead of ioremap())
use pci_iomap)
* some "while" loops could be rewritten with simple "for", ex.
ql_wait_reg_rdy(), ql_start_rx_ring())
* remove duplicate and useless comments * remove duplicate and useless comments
* fix weird line wrapping (all over, ex. the ql_set_routing_reg() calls in * fix weird line wrapping (all over, ex. the qlge_set_routing_reg() calls in
qlge_set_multicast_list()). qlge_set_multicast_list()).
* fix weird indentation (all over, ex. the for loops in qlge_get_stats()) * remove useless casts (ex. memset((void *)mac_iocb_ptr, ...))
* fix checkpatch issues * fix checkpatch issues
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment