Commit 890766d2 authored by Ezequiel Garcia's avatar Ezequiel Garcia Committed by Dan Williams

dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call

In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots()
when the transaction is complete (the cookie status is DMA_COMPLETE).
However, a completed status means that mv_xor_slot_cleanup() was called,
which cleans the completed slots.

In other words, there's nothing to cleanup for a completed transaction in
mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots().
Reported-by: default avatarDan Williams <dan.j.williams@intel.com>
Signed-off-by: default avatarEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 368da992
...@@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan, ...@@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan,
enum dma_status ret; enum dma_status ret;
ret = dma_cookie_status(chan, cookie, txstate); ret = dma_cookie_status(chan, cookie, txstate);
if (ret == DMA_COMPLETE) { if (ret == DMA_COMPLETE)
mv_xor_clean_completed_slots(mv_chan);
return ret; return ret;
}
mv_xor_slot_cleanup(mv_chan); mv_xor_slot_cleanup(mv_chan);
return dma_cookie_status(chan, cookie, txstate); return dma_cookie_status(chan, cookie, txstate);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment