Commit 893aa09e authored by Wang Ming's avatar Wang Ming Committed by Mark Brown

spi: Use dev_err_probe instead of dev_err

It is possible that dma_request_chan will return EPROBE_DEFER,
which means that dev is not ready yet. In this case,
dev_err(dev), there will be no output. This patch fixes the bug.
Signed-off-by: default avatarWang Ming <machel@vivo.com>
Link: https://lore.kernel.org/r/20230726105457.3743-1-machel@vivo.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4ee0fecc
...@@ -903,15 +903,15 @@ static int bcm2835_dma_init(struct spi_controller *ctlr, struct device *dev, ...@@ -903,15 +903,15 @@ static int bcm2835_dma_init(struct spi_controller *ctlr, struct device *dev,
/* get tx/rx dma */ /* get tx/rx dma */
ctlr->dma_tx = dma_request_chan(dev, "tx"); ctlr->dma_tx = dma_request_chan(dev, "tx");
if (IS_ERR(ctlr->dma_tx)) { if (IS_ERR(ctlr->dma_tx)) {
dev_err(dev, "no tx-dma configuration found - not using dma mode\n"); ret = dev_err_probe(dev, PTR_ERR(ctlr->dma_tx),
ret = PTR_ERR(ctlr->dma_tx); "no tx-dma configuration found - not using dma mode\n");
ctlr->dma_tx = NULL; ctlr->dma_tx = NULL;
goto err; goto err;
} }
ctlr->dma_rx = dma_request_chan(dev, "rx"); ctlr->dma_rx = dma_request_chan(dev, "rx");
if (IS_ERR(ctlr->dma_rx)) { if (IS_ERR(ctlr->dma_rx)) {
dev_err(dev, "no rx-dma configuration found - not using dma mode\n"); ret = dev_err_probe(dev, PTR_ERR(ctlr->dma_rx),
ret = PTR_ERR(ctlr->dma_rx); "no rx-dma configuration found - not using dma mode\n");
ctlr->dma_rx = NULL; ctlr->dma_rx = NULL;
goto err_release; goto err_release;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment