Commit 8b21900b authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen

scsi: qla2xxx: Remove two superfluous tests

Since qlt_remove_target() only calls qlt_release() if
vha->vha_tgt.qla_tgt != NULL, checking that pointer inside qlt_release()
is not necessary. This patch fixes the following Coverity complaint:

CID 188348 (#1 of 1): Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer &vha->vha_tgt.qla_tgt->tgt_list_entry
to list_del, which dereferences it.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Tested-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Reviewed-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 53be100b
...@@ -1580,11 +1580,10 @@ static void qlt_release(struct qla_tgt *tgt) ...@@ -1580,11 +1580,10 @@ static void qlt_release(struct qla_tgt *tgt)
struct qla_qpair_hint *h; struct qla_qpair_hint *h;
struct qla_hw_data *ha = vha->hw; struct qla_hw_data *ha = vha->hw;
if ((vha->vha_tgt.qla_tgt != NULL) && !tgt->tgt_stop && if (!tgt->tgt_stop && !tgt->tgt_stopped)
!tgt->tgt_stopped)
qlt_stop_phase1(tgt); qlt_stop_phase1(tgt);
if ((vha->vha_tgt.qla_tgt != NULL) && !tgt->tgt_stopped) if (!tgt->tgt_stopped)
qlt_stop_phase2(tgt); qlt_stop_phase2(tgt);
for (i = 0; i < vha->hw->max_qpairs + 1; i++) { for (i = 0; i < vha->hw->max_qpairs + 1; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment