Commit 8b42057e authored by Liang He's avatar Liang He Committed by Tomi Valkeinen

drm/omap: dss: Fix refcount leak bugs

In dss_init_ports() and __dss_uninit_ports(), we should call
of_node_put() for the reference returned by of_graph_get_port_by_id()
in fail path or when it is not used anymore.

Fixes: 09bffa6e ("drm: omap: use common OF graph helpers")
Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220722144348.1306569-1-windhl@126.com
parent e8523f53
...@@ -1176,6 +1176,7 @@ static void __dss_uninit_ports(struct dss_device *dss, unsigned int num_ports) ...@@ -1176,6 +1176,7 @@ static void __dss_uninit_ports(struct dss_device *dss, unsigned int num_ports)
default: default:
break; break;
} }
of_node_put(port);
} }
} }
...@@ -1208,11 +1209,13 @@ static int dss_init_ports(struct dss_device *dss) ...@@ -1208,11 +1209,13 @@ static int dss_init_ports(struct dss_device *dss)
default: default:
break; break;
} }
of_node_put(port);
} }
return 0; return 0;
error: error:
of_node_put(port);
__dss_uninit_ports(dss, i); __dss_uninit_ports(dss, i);
return r; return r;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment