Commit 8e09b7d2 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by John W. Linville

wil6210: Fix potential memory leaks on error paths

Fix missing memory deallocation on error paths in wil_write_file_wmi()
and wil_write_file_txmgmt().
Reported-by: default avatarAhmed Tamrawi <ahmedtamrawi@gmail.com>
Signed-off-by: default avatarLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent cbe1bc23
...@@ -573,8 +573,10 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, ...@@ -573,8 +573,10 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf,
if (!frame) if (!frame)
return -ENOMEM; return -ENOMEM;
if (copy_from_user(frame, buf, len)) if (copy_from_user(frame, buf, len)) {
kfree(frame);
return -EIO; return -EIO;
}
params.buf = frame; params.buf = frame;
params.len = len; params.len = len;
...@@ -614,8 +616,10 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf, ...@@ -614,8 +616,10 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf,
return -ENOMEM; return -ENOMEM;
rc = simple_write_to_buffer(wmi, len, ppos, buf, len); rc = simple_write_to_buffer(wmi, len, ppos, buf, len);
if (rc < 0) if (rc < 0) {
kfree(wmi);
return rc; return rc;
}
cmd = &wmi[1]; cmd = &wmi[1];
cmdid = le16_to_cpu(wmi->id); cmdid = le16_to_cpu(wmi->id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment