Commit 9027f611 authored by Takashi Iwai's avatar Takashi Iwai Committed by Sebastian Reichel

power: twl4030: Use scnprintf() for avoiding potential buffer overflow

Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit.  Fix it by replacing with scnprintf().
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSebastian Reichel <sebastian.reichel@collabora.com>
parent 583b53ec
...@@ -726,10 +726,10 @@ twl4030_bci_mode_show(struct device *dev, ...@@ -726,10 +726,10 @@ twl4030_bci_mode_show(struct device *dev,
for (i = 0; i < ARRAY_SIZE(modes); i++) for (i = 0; i < ARRAY_SIZE(modes); i++)
if (mode == i) if (mode == i)
len += snprintf(buf+len, PAGE_SIZE-len, len += scnprintf(buf+len, PAGE_SIZE-len,
"[%s] ", modes[i]); "[%s] ", modes[i]);
else else
len += snprintf(buf+len, PAGE_SIZE-len, len += scnprintf(buf+len, PAGE_SIZE-len,
"%s ", modes[i]); "%s ", modes[i]);
buf[len-1] = '\n'; buf[len-1] = '\n';
return len; return len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment