Commit 908f61be authored by Radhey Shyam Pandey's avatar Radhey Shyam Pandey Committed by Greg Kroah-Hartman

usb: misc: onboard_dev: extend platform data to add power on delay field

Introduce dedicated field 'power_on_delay_us' in onboard platform data
and update its delay for USB5744 configuration. Hub itself requires some
delay after reset to get to state where configuration data is going to
be accepted. Without delay upcoming support for configuration via SMBUS
is reporting a failure on the first SMBus write.

i2c 2-002d: error -ENXIO: BYPASS_UDC_SUSPEND bit configuration failed

Similar delay is likely also required for default configuration but
because there is enough time (code execution) between reset and usage
of the hub any issue is not visible but it doesn't mean delay shouldn't
be reflected.
Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Suggested-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Link: https://lore.kernel.org/r/1725732196-70975-2-git-send-email-radhey.shyam.pandey@amd.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2c6b6afa
...@@ -98,6 +98,7 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev) ...@@ -98,6 +98,7 @@ static int onboard_dev_power_on(struct onboard_dev *onboard_dev)
fsleep(onboard_dev->pdata->reset_us); fsleep(onboard_dev->pdata->reset_us);
gpiod_set_value_cansleep(onboard_dev->reset_gpio, 0); gpiod_set_value_cansleep(onboard_dev->reset_gpio, 0);
fsleep(onboard_dev->pdata->power_on_delay_us);
onboard_dev->is_powered_on = true; onboard_dev->is_powered_on = true;
......
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
struct onboard_dev_pdata { struct onboard_dev_pdata {
unsigned long reset_us; /* reset pulse width in us */ unsigned long reset_us; /* reset pulse width in us */
unsigned long power_on_delay_us; /* power on delay in us */
unsigned int num_supplies; /* number of supplies */ unsigned int num_supplies; /* number of supplies */
const char * const supply_names[MAX_SUPPLIES]; const char * const supply_names[MAX_SUPPLIES];
bool is_hub; bool is_hub;
...@@ -24,6 +25,7 @@ static const struct onboard_dev_pdata microchip_usb424_data = { ...@@ -24,6 +25,7 @@ static const struct onboard_dev_pdata microchip_usb424_data = {
static const struct onboard_dev_pdata microchip_usb5744_data = { static const struct onboard_dev_pdata microchip_usb5744_data = {
.reset_us = 0, .reset_us = 0,
.power_on_delay_us = 10000,
.num_supplies = 2, .num_supplies = 2,
.supply_names = { "vdd", "vdd2" }, .supply_names = { "vdd", "vdd2" },
.is_hub = true, .is_hub = true,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment