Commit 9283f534 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: venus: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent d8025081
...@@ -416,7 +416,7 @@ static int venus_probe(struct platform_device *pdev) ...@@ -416,7 +416,7 @@ static int venus_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int venus_remove(struct platform_device *pdev) static void venus_remove(struct platform_device *pdev)
{ {
struct venus_core *core = platform_get_drvdata(pdev); struct venus_core *core = platform_get_drvdata(pdev);
const struct venus_pm_ops *pm_ops = core->pm_ops; const struct venus_pm_ops *pm_ops = core->pm_ops;
...@@ -447,8 +447,6 @@ static int venus_remove(struct platform_device *pdev) ...@@ -447,8 +447,6 @@ static int venus_remove(struct platform_device *pdev)
mutex_destroy(&core->pm_lock); mutex_destroy(&core->pm_lock);
mutex_destroy(&core->lock); mutex_destroy(&core->lock);
venus_dbgfs_deinit(core); venus_dbgfs_deinit(core);
return 0;
} }
static void venus_core_shutdown(struct platform_device *pdev) static void venus_core_shutdown(struct platform_device *pdev)
...@@ -891,7 +889,7 @@ MODULE_DEVICE_TABLE(of, venus_dt_match); ...@@ -891,7 +889,7 @@ MODULE_DEVICE_TABLE(of, venus_dt_match);
static struct platform_driver qcom_venus_driver = { static struct platform_driver qcom_venus_driver = {
.probe = venus_probe, .probe = venus_probe,
.remove = venus_remove, .remove_new = venus_remove,
.driver = { .driver = {
.name = "qcom-venus", .name = "qcom-venus",
.of_match_table = venus_dt_match, .of_match_table = venus_dt_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment