Commit 95bdba23 authored by David Ahern's avatar David Ahern Committed by Jakub Kicinski

ipv6: Do cleanup if attribute validation fails in multipath route

As Nicolas noted, if gateway validation fails walking the multipath
attribute the code should jump to the cleanup to free previously
allocated memory.

Fixes: 1ff15a71 ("ipv6: Check attribute length for RTA_GATEWAY when deleting multipath route")
Signed-off-by: default avatarDavid Ahern <dsahern@kernel.org>
Acked-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20220103170555.94638-1-dsahern@kernel.orgSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e30a845b
...@@ -5277,12 +5277,10 @@ static int ip6_route_multipath_add(struct fib6_config *cfg, ...@@ -5277,12 +5277,10 @@ static int ip6_route_multipath_add(struct fib6_config *cfg,
nla = nla_find(attrs, attrlen, RTA_GATEWAY); nla = nla_find(attrs, attrlen, RTA_GATEWAY);
if (nla) { if (nla) {
int ret; err = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
ret = fib6_gw_from_attr(&r_cfg.fc_gateway, nla,
extack); extack);
if (ret) if (err)
return ret; goto cleanup;
r_cfg.fc_flags |= RTF_GATEWAY; r_cfg.fc_flags |= RTF_GATEWAY;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment