Commit 9735bde3 authored by Fenghua Yu's avatar Fenghua Yu Committed by Vinod Koul

dmaengine: idxd: Set traffic class values in GRPCFG on DSA 2.0

On DSA/IAX 1.0, TC-A and TC-B in GRPCFG are set as 1 to have best
performance and cannot be changed through sysfs knobs unless override
option is given.

The same values should be set on DSA 2.0 as well.

Fixes: ea7c8f59 ("dmaengine: idxd: restore traffic class defaults after wq reset")
Fixes: ade8a86b ("dmaengine: idxd: Set defaults for GRPCFG traffic class")
Signed-off-by: default avatarFenghua Yu <fenghua.yu@intel.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20221209172141.562648-1-fenghua.yu@intel.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 5840c891
...@@ -701,7 +701,7 @@ static void idxd_groups_clear_state(struct idxd_device *idxd) ...@@ -701,7 +701,7 @@ static void idxd_groups_clear_state(struct idxd_device *idxd)
group->use_rdbuf_limit = false; group->use_rdbuf_limit = false;
group->rdbufs_allowed = 0; group->rdbufs_allowed = 0;
group->rdbufs_reserved = 0; group->rdbufs_reserved = 0;
if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) { if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
group->tc_a = 1; group->tc_a = 1;
group->tc_b = 1; group->tc_b = 1;
} else { } else {
......
...@@ -295,7 +295,7 @@ static int idxd_setup_groups(struct idxd_device *idxd) ...@@ -295,7 +295,7 @@ static int idxd_setup_groups(struct idxd_device *idxd)
} }
idxd->groups[i] = group; idxd->groups[i] = group;
if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) { if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override) {
group->tc_a = 1; group->tc_a = 1;
group->tc_b = 1; group->tc_b = 1;
} else { } else {
......
...@@ -387,7 +387,7 @@ static ssize_t group_traffic_class_a_store(struct device *dev, ...@@ -387,7 +387,7 @@ static ssize_t group_traffic_class_a_store(struct device *dev,
if (idxd->state == IDXD_DEV_ENABLED) if (idxd->state == IDXD_DEV_ENABLED)
return -EPERM; return -EPERM;
if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
return -EPERM; return -EPERM;
if (val < 0 || val > 7) if (val < 0 || val > 7)
...@@ -429,7 +429,7 @@ static ssize_t group_traffic_class_b_store(struct device *dev, ...@@ -429,7 +429,7 @@ static ssize_t group_traffic_class_b_store(struct device *dev,
if (idxd->state == IDXD_DEV_ENABLED) if (idxd->state == IDXD_DEV_ENABLED)
return -EPERM; return -EPERM;
if (idxd->hw.version < DEVICE_VERSION_2 && !tc_override) if (idxd->hw.version <= DEVICE_VERSION_2 && !tc_override)
return -EPERM; return -EPERM;
if (val < 0 || val > 7) if (val < 0 || val > 7)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment