Commit 99218cbf authored by Miaoqian Lin's avatar Miaoqian Lin Committed by David S. Miller

lib82596: Fix IRQ check in sni_82596_probe

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 11597885 ("i825xx: Move the Intel 82586/82593/82596 based drivers")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ea938248
...@@ -117,9 +117,10 @@ static int sni_82596_probe(struct platform_device *dev) ...@@ -117,9 +117,10 @@ static int sni_82596_probe(struct platform_device *dev)
netdevice->dev_addr[5] = readb(eth_addr + 0x06); netdevice->dev_addr[5] = readb(eth_addr + 0x06);
iounmap(eth_addr); iounmap(eth_addr);
if (!netdevice->irq) { if (netdevice->irq < 0) {
printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n", printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
__FILE__, netdevice->base_addr); __FILE__, netdevice->base_addr);
retval = netdevice->irq;
goto probe_failed; goto probe_failed;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment