Commit 9bab71eb authored by Zhang Bo's avatar Zhang Bo Committed by Greg Kroah-Hartman

Input: matrix_keypad - fix race when disabling interrupts

commit ea4f7bd2 upstream.

If matrix_keypad_stop() is executing and the keypad interrupt is triggered,
disable_row_irqs() may be called by both matrix_keypad_interrupt() and
matrix_keypad_stop() at the same time, causing interrupts to be disabled
twice and the keypad being "stuck" after resuming.

Take lock when setting keypad->stopped to ensure that ISR will not race
with matrix_keypad_stop() disabling interrupts.
Signed-off-by: default avatarZhang Bo <zbsdta@126.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 175b57ba
...@@ -216,8 +216,10 @@ static void matrix_keypad_stop(struct input_dev *dev) ...@@ -216,8 +216,10 @@ static void matrix_keypad_stop(struct input_dev *dev)
{ {
struct matrix_keypad *keypad = input_get_drvdata(dev); struct matrix_keypad *keypad = input_get_drvdata(dev);
spin_lock_irq(&keypad->lock);
keypad->stopped = true; keypad->stopped = true;
mb(); spin_unlock_irq(&keypad->lock);
flush_work(&keypad->work.work); flush_work(&keypad->work.work);
/* /*
* matrix_keypad_scan() will leave IRQs enabled; * matrix_keypad_scan() will leave IRQs enabled;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment