Commit 9c361b1a authored by Dan Carpenter's avatar Dan Carpenter Committed by Vinod Koul

dmaengine: xgene: devm_ioremap() returns NULL on error

The code here is checking for IS_ERR() but devm_ioremap() returns NULL
on error and not an error pointer.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent ed1f0418
...@@ -1895,9 +1895,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev, ...@@ -1895,9 +1895,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_dma = devm_ioremap(&pdev->dev, res->start, pdma->csr_dma = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (IS_ERR(pdma->csr_dma)) { if (!pdma->csr_dma) {
dev_err(&pdev->dev, "Failed to ioremap csr region"); dev_err(&pdev->dev, "Failed to ioremap csr region");
return PTR_ERR(pdma->csr_dma); return -ENOMEM;
} }
/* Get DMA ring csr region */ /* Get DMA ring csr region */
...@@ -1909,9 +1909,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev, ...@@ -1909,9 +1909,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_ring = devm_ioremap(&pdev->dev, res->start, pdma->csr_ring = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (IS_ERR(pdma->csr_ring)) { if (!pdma->csr_ring) {
dev_err(&pdev->dev, "Failed to ioremap ring csr region"); dev_err(&pdev->dev, "Failed to ioremap ring csr region");
return PTR_ERR(pdma->csr_ring); return -ENOMEM;
} }
/* Get DMA ring cmd csr region */ /* Get DMA ring cmd csr region */
...@@ -1923,9 +1923,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev, ...@@ -1923,9 +1923,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_ring_cmd = devm_ioremap(&pdev->dev, res->start, pdma->csr_ring_cmd = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (IS_ERR(pdma->csr_ring_cmd)) { if (!pdma->csr_ring_cmd) {
dev_err(&pdev->dev, "Failed to ioremap ring cmd csr region"); dev_err(&pdev->dev, "Failed to ioremap ring cmd csr region");
return PTR_ERR(pdma->csr_ring_cmd); return -ENOMEM;
} }
/* Get efuse csr region */ /* Get efuse csr region */
...@@ -1937,9 +1937,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev, ...@@ -1937,9 +1937,9 @@ static int xgene_dma_get_resources(struct platform_device *pdev,
pdma->csr_efuse = devm_ioremap(&pdev->dev, res->start, pdma->csr_efuse = devm_ioremap(&pdev->dev, res->start,
resource_size(res)); resource_size(res));
if (IS_ERR(pdma->csr_efuse)) { if (!pdma->csr_efuse) {
dev_err(&pdev->dev, "Failed to ioremap efuse csr region"); dev_err(&pdev->dev, "Failed to ioremap efuse csr region");
return PTR_ERR(pdma->csr_efuse); return -ENOMEM;
} }
/* Get DMA error interrupt */ /* Get DMA error interrupt */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment