Commit 9c6464dc authored by Dejin Zheng's avatar Dejin Zheng Committed by David S. Miller

net: phy: aquantia: use phy_read_mmd_poll_timeout() to simplify the code

use phy_read_mmd_poll_timeout() to replace the poll codes for
simplify aqr107_wait_reset_complete() function.
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 331c7372
...@@ -434,16 +434,11 @@ static int aqr107_set_tunable(struct phy_device *phydev, ...@@ -434,16 +434,11 @@ static int aqr107_set_tunable(struct phy_device *phydev,
*/ */
static int aqr107_wait_reset_complete(struct phy_device *phydev) static int aqr107_wait_reset_complete(struct phy_device *phydev)
{ {
int val, retries = 100; int val;
do {
val = phy_read_mmd(phydev, MDIO_MMD_VEND1, VEND1_GLOBAL_FW_ID);
if (val < 0)
return val;
msleep(20);
} while (!val && --retries);
return val ? 0 : -ETIMEDOUT; return phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1,
VEND1_GLOBAL_FW_ID, val, val != 0,
20000, 2000000, false);
} }
static void aqr107_chip_info(struct phy_device *phydev) static void aqr107_chip_info(struct phy_device *phydev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment