Commit 9d72fe1c authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Borislav Petkov

EDAC, altera: Fix an error handling path in altr_s10_sdram_probe()

If regmap_write() fails, we should release some resources as done in all
the other error handling paths of the function.
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarThor Thayer <thor.thayer@linux.intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/20180610174532.22071-1-christophe.jaillet@wanadoo.fr
Fixes: e9918d7f ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
Signed-off-by: default avatarBorislav Petkov <bp@suse.de>
parent ce397d21
...@@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev) ...@@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev)
S10_DDR0_IRQ_MASK)) { S10_DDR0_IRQ_MASK)) {
edac_printk(KERN_ERR, EDAC_MC, edac_printk(KERN_ERR, EDAC_MC,
"Error clearing SDRAM ECC count\n"); "Error clearing SDRAM ECC count\n");
return -ENODEV; ret = -ENODEV;
goto err2;
} }
if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset, if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment