Commit 9fe17d2a authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini

KVM: x86/mmu: Clean up make_huge_page_split_spte() definition and intro

Tweak the definition of make_huge_page_split_spte() to eliminate an
unnecessarily long line, and opportunistically initialize child_spte to
make it more obvious that the child is directly derived from the huge
parent.

No functional change intended.
Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-ID: <20240712151335.1242633-3-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 3d4415ed
...@@ -291,15 +291,13 @@ static u64 make_spte_executable(u64 spte) ...@@ -291,15 +291,13 @@ static u64 make_spte_executable(u64 spte)
* This is used during huge page splitting to build the SPTEs that make up the * This is used during huge page splitting to build the SPTEs that make up the
* new page table. * new page table.
*/ */
u64 make_huge_page_split_spte(struct kvm *kvm, u64 huge_spte, union kvm_mmu_page_role role, u64 make_huge_page_split_spte(struct kvm *kvm, u64 huge_spte,
int index) union kvm_mmu_page_role role, int index)
{ {
u64 child_spte; u64 child_spte = huge_spte;
KVM_BUG_ON(!is_shadow_present_pte(huge_spte) || !is_large_pte(huge_spte), kvm); KVM_BUG_ON(!is_shadow_present_pte(huge_spte) || !is_large_pte(huge_spte), kvm);
child_spte = huge_spte;
/* /*
* The child_spte already has the base address of the huge page being * The child_spte already has the base address of the huge page being
* split. So we just have to OR in the offset to the page at the next * split. So we just have to OR in the offset to the page at the next
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment