[NET]: More error checking in flow cache init function.

a116ffd9 · Herbert Xu · David S. Miller · b73c3156 · a116ffd9
Commit a116ffd9 authored Jun 19, 2003 by Herbert Xu Committed by David S. Miller Jun 19, 2003
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 5 deletions

net/core/flow.c net/core/flow.c +8 -5

No files found.
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -388,10 +388,13 @@ static int __init flow_cache_init(void)
 	add_timer(&flow_hash_rnd_timer);
 	register_cpu_notifier(&flow_cache_cpu_nb);
-	for (i = 0; i < NR_CPUS; i++)
+	for (i = 0; i < NR_CPUS; i++) {
-		if (cpu_online(i)) {
+		if (!cpu_online(i))
-			flow_cache_cpu_prepare(i);
+			continue;
-			flow_cache_cpu_online(i);
+		if (flow_cache_cpu_prepare(i) == NOTIFY_OK &&
+		    flow_cache_cpu_online(i) == NOTIFY_OK)
+			continue;
+		panic("NET: failed to initialise flow cache hash table\n");
 	}
 	return 0;