Commit a2041761 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe

block: warn when putting the final reference on a registered disk

Warn when the last reference on a live disk is put without calling
del_gendisk first.  There are some BDI related bug reports that look
like a case of this, so make sure we have the proper instrumentation
to catch it.
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20211014130231.1468538-1-hch@lst.deSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f7bf3586
...@@ -1078,6 +1078,7 @@ static void disk_release(struct device *dev) ...@@ -1078,6 +1078,7 @@ static void disk_release(struct device *dev)
struct gendisk *disk = dev_to_disk(dev); struct gendisk *disk = dev_to_disk(dev);
might_sleep(); might_sleep();
WARN_ON_ONCE(disk_live(disk));
disk_release_events(disk); disk_release_events(disk);
kfree(disk->random); kfree(disk->random);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment