Commit a3d3eab6 authored by Jaewon Kim's avatar Jaewon Kim Committed by Mark Brown

spi: s3c64xx: Use DMA mode from fifo size

If the SPI data size is smaller than FIFO, it operates in PIO mode,
and if it is larger than FIFO size, it oerates in DMA mode.

If the SPI data size is equal to fifo, it operates in PIO mode and it is
separated to 2 transfers. To prevent it, it must operate in DMA mode
from the case where the data size and the fifo size are the same.

Fixes: 1ee80671 ("spi: s3c64xx: support interrupt based pio mode")
Signed-off-by: default avatarJaewon Kim <jaewon02.kim@samsung.com>
Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Link: https://lore.kernel.org/r/20240329085840.65856-1-jaewon02.kim@samsung.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 4cece764
...@@ -430,7 +430,7 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host, ...@@ -430,7 +430,7 @@ static bool s3c64xx_spi_can_dma(struct spi_controller *host,
struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host); struct s3c64xx_spi_driver_data *sdd = spi_controller_get_devdata(host);
if (sdd->rx_dma.ch && sdd->tx_dma.ch) if (sdd->rx_dma.ch && sdd->tx_dma.ch)
return xfer->len > sdd->fifo_depth; return xfer->len >= sdd->fifo_depth;
return false; return false;
} }
...@@ -826,10 +826,9 @@ static int s3c64xx_spi_transfer_one(struct spi_controller *host, ...@@ -826,10 +826,9 @@ static int s3c64xx_spi_transfer_one(struct spi_controller *host,
return status; return status;
} }
if (!is_polling(sdd) && (xfer->len > fifo_len) && if (!is_polling(sdd) && xfer->len >= fifo_len &&
sdd->rx_dma.ch && sdd->tx_dma.ch) { sdd->rx_dma.ch && sdd->tx_dma.ch) {
use_dma = 1; use_dma = 1;
} else if (xfer->len >= fifo_len) { } else if (xfer->len >= fifo_len) {
tx_buf = xfer->tx_buf; tx_buf = xfer->tx_buf;
rx_buf = xfer->rx_buf; rx_buf = xfer->rx_buf;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment