Commit a508e339 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Corey Minyard

ipmi:ipmb: Fix refcount leak in ipmi_ipmb_probe

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 00d93611 ("ipmi:ipmb: Add the ability to have a separate slave and master device")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Message-Id: <20220512044445.3102-1-linmq006@gmail.com>
Cc: stable@vger.kernel.org # v5.17+
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 5396ccbd
...@@ -475,6 +475,7 @@ static int ipmi_ipmb_probe(struct i2c_client *client) ...@@ -475,6 +475,7 @@ static int ipmi_ipmb_probe(struct i2c_client *client)
slave_np = of_parse_phandle(dev->of_node, "slave-dev", 0); slave_np = of_parse_phandle(dev->of_node, "slave-dev", 0);
if (slave_np) { if (slave_np) {
slave_adap = of_get_i2c_adapter_by_node(slave_np); slave_adap = of_get_i2c_adapter_by_node(slave_np);
of_node_put(slave_np);
if (!slave_adap) { if (!slave_adap) {
dev_notice(&client->dev, dev_notice(&client->dev,
"Could not find slave adapter\n"); "Could not find slave adapter\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment