Commit a59e9eb2 authored by Julia Lawall's avatar Julia Lawall Committed by Michael Ellerman

powerpc/powermac: add missing of_node_put

for_each_node_by_name performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230907095521.14053-4-Julia.Lawall@inria.fr
parent ce9ecca0
...@@ -925,8 +925,10 @@ static void __init smu_i2c_probe(void) ...@@ -925,8 +925,10 @@ static void __init smu_i2c_probe(void)
sz = sizeof(struct pmac_i2c_bus) + sizeof(struct smu_i2c_cmd); sz = sizeof(struct pmac_i2c_bus) + sizeof(struct smu_i2c_cmd);
bus = kzalloc(sz, GFP_KERNEL); bus = kzalloc(sz, GFP_KERNEL);
if (bus == NULL) if (bus == NULL) {
of_node_put(busnode);
return; return;
}
bus->controller = controller; bus->controller = controller;
bus->busnode = of_node_get(busnode); bus->busnode = of_node_get(busnode);
......
...@@ -598,9 +598,11 @@ static void __init smp_core99_setup_i2c_hwsync(int ncpus) ...@@ -598,9 +598,11 @@ static void __init smp_core99_setup_i2c_hwsync(int ncpus)
name = "Pulsar"; name = "Pulsar";
break; break;
} }
if (pmac_tb_freeze != NULL) if (pmac_tb_freeze != NULL) {
of_node_put(cc);
break; break;
} }
}
if (pmac_tb_freeze != NULL) { if (pmac_tb_freeze != NULL) {
/* Open i2c bus for synchronous access */ /* Open i2c bus for synchronous access */
if (pmac_i2c_open(pmac_tb_clock_chip_host, 1)) { if (pmac_i2c_open(pmac_tb_clock_chip_host, 1)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment