Commit a7e57930 authored by Johannes Berg's avatar Johannes Berg

wifi: nl80211: don't give key data to userspace

When a key is requested by userspace, there's really no need
to include the key data, the sequence counter is really what
userspace needs in this case. The fact that it's included is
just a historic quirk.

Remove the key data.
Reviewed-by: default avatarMiriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20240627104411.b6a4f097e4ea.I7e6cc976cb9e8a80ef25a3351330f313373b4578@changeidSigned-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 94833add
...@@ -4487,10 +4487,7 @@ static void get_key_callback(void *c, struct key_params *params) ...@@ -4487,10 +4487,7 @@ static void get_key_callback(void *c, struct key_params *params)
struct nlattr *key; struct nlattr *key;
struct get_key_cookie *cookie = c; struct get_key_cookie *cookie = c;
if ((params->key && if ((params->seq &&
nla_put(cookie->msg, NL80211_ATTR_KEY_DATA,
params->key_len, params->key)) ||
(params->seq &&
nla_put(cookie->msg, NL80211_ATTR_KEY_SEQ, nla_put(cookie->msg, NL80211_ATTR_KEY_SEQ,
params->seq_len, params->seq)) || params->seq_len, params->seq)) ||
(params->cipher && (params->cipher &&
...@@ -4502,10 +4499,7 @@ static void get_key_callback(void *c, struct key_params *params) ...@@ -4502,10 +4499,7 @@ static void get_key_callback(void *c, struct key_params *params)
if (!key) if (!key)
goto nla_put_failure; goto nla_put_failure;
if ((params->key && if ((params->seq &&
nla_put(cookie->msg, NL80211_KEY_DATA,
params->key_len, params->key)) ||
(params->seq &&
nla_put(cookie->msg, NL80211_KEY_SEQ, nla_put(cookie->msg, NL80211_KEY_SEQ,
params->seq_len, params->seq)) || params->seq_len, params->seq)) ||
(params->cipher && (params->cipher &&
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment