Commit ab1151d8 authored by David Hildenbrand's avatar David Hildenbrand Committed by Kleber Sacilotto de Souza

powerpc/pseries/cmm: Implement release() function for sysfs device

BugLink: https://bugs.launchpad.net/bugs/1858462

[ Upstream commit 7d821274 ]

When unloading the module, one gets
  ------------[ cut here ]------------
  Device 'cmm0' does not have a release() function, it is broken and must be fixed. See Documentation/kobject.txt.
  WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .device_release+0xcc/0xf0
  ...

We only have one static fake device. There is nothing to do when
releasing the device (via cmm_exit()).
Signed-off-by: default avatarDavid Hildenbrand <david@redhat.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191031142933.10779-2-david@redhat.comSigned-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarConnor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 5f90b290
...@@ -391,6 +391,10 @@ static struct bus_type cmm_subsys = { ...@@ -391,6 +391,10 @@ static struct bus_type cmm_subsys = {
.dev_name = "cmm", .dev_name = "cmm",
}; };
static void cmm_release_device(struct device *dev)
{
}
/** /**
* cmm_sysfs_register - Register with sysfs * cmm_sysfs_register - Register with sysfs
* *
...@@ -406,6 +410,7 @@ static int cmm_sysfs_register(struct device *dev) ...@@ -406,6 +410,7 @@ static int cmm_sysfs_register(struct device *dev)
dev->id = 0; dev->id = 0;
dev->bus = &cmm_subsys; dev->bus = &cmm_subsys;
dev->release = cmm_release_device;
if ((rc = device_register(dev))) if ((rc = device_register(dev)))
goto subsys_unregister; goto subsys_unregister;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment