Commit ab34291d authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: connection: fix duplicating naming in _gb_hd_connection_insert()

Though this doesn't cause any logical issues as far as the behavior of the
routine is concerned as the local variable would be considered inside the
'while' loop.

But its better not to use the same name for variables at different levels.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
parent 1dd90df4
......@@ -23,13 +23,13 @@ static void _gb_hd_connection_insert(struct greybus_host_device *hd,
u16 cport_id = connection->hd_cport_id;
while (*link) {
struct gb_connection *connection;
struct gb_connection *_connection;
above = *link;
connection = rb_entry(above, struct gb_connection, hd_node);
if (connection->hd_cport_id > cport_id)
_connection = rb_entry(above, struct gb_connection, hd_node);
if (_connection->hd_cport_id > cport_id)
link = &above->rb_left;
else if (connection->hd_cport_id < cport_id)
else if (_connection->hd_cport_id < cport_id)
link = &above->rb_right;
}
rb_link_node(node, above, link);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment