Commit ad0e4e2f authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Martin K. Petersen

scsi: snic: Fix memory leak with using debugfs_lookup()

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic at
once.

Link: https://lore.kernel.org/r/20230202141009.2290380-1-gregkh@linuxfoundation.org
Cc: Karan Tilak Kumar <kartilak@cisco.com>
Cc: Sesidhar Baddela <sebaddel@cisco.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 339aa122
...@@ -437,6 +437,6 @@ void snic_trc_debugfs_init(void) ...@@ -437,6 +437,6 @@ void snic_trc_debugfs_init(void)
void void
snic_trc_debugfs_term(void) snic_trc_debugfs_term(void)
{ {
debugfs_remove(debugfs_lookup(TRC_FILE, snic_glob->trc_root)); debugfs_lookup_and_remove(TRC_FILE, snic_glob->trc_root);
debugfs_remove(debugfs_lookup(TRC_ENABLE_FILE, snic_glob->trc_root)); debugfs_lookup_and_remove(TRC_ENABLE_FILE, snic_glob->trc_root);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment