Commit ae1b6a31 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller

[AX25]: Potential ax25_uid_assoc-s leaks on module unload.

The ax25_uid_free call walks the ax25_uid_list and releases entries
from it. The problem is that after the fisrt call to hlist_del_init
the hlist_for_each_entry (which hides behind the ax25_uid_for_each)
will consider the current position to be the last and will return.

Thus, the whole list will be left not freed.
Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2de58e30
...@@ -218,9 +218,11 @@ void __exit ax25_uid_free(void) ...@@ -218,9 +218,11 @@ void __exit ax25_uid_free(void)
struct hlist_node *node; struct hlist_node *node;
write_lock(&ax25_uid_lock); write_lock(&ax25_uid_lock);
again:
ax25_uid_for_each(ax25_uid, node, &ax25_uid_list) { ax25_uid_for_each(ax25_uid, node, &ax25_uid_list) {
hlist_del_init(&ax25_uid->uid_node); hlist_del_init(&ax25_uid->uid_node);
ax25_uid_put(ax25_uid); ax25_uid_put(ax25_uid);
goto again;
} }
write_unlock(&ax25_uid_lock); write_unlock(&ax25_uid_lock);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment