Commit ae382c22 authored by Oded Gabbay's avatar Oded Gabbay

habanalabs: use strscpy instead of sprintf and strlcpy

Prefer the use of strscpy when copying the ASIC name into a char array,
to prevent accidentally exceeding the array's length.
In addition, strlcpy is frowned upon so replace it.
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 131d1ba1
...@@ -321,11 +321,11 @@ static int device_early_init(struct hl_device *hdev) ...@@ -321,11 +321,11 @@ static int device_early_init(struct hl_device *hdev)
switch (hdev->asic_type) { switch (hdev->asic_type) {
case ASIC_GOYA: case ASIC_GOYA:
goya_set_asic_funcs(hdev); goya_set_asic_funcs(hdev);
strlcpy(hdev->asic_name, "GOYA", sizeof(hdev->asic_name)); strscpy(hdev->asic_name, "GOYA", sizeof(hdev->asic_name));
break; break;
case ASIC_GAUDI: case ASIC_GAUDI:
gaudi_set_asic_funcs(hdev); gaudi_set_asic_funcs(hdev);
sprintf(hdev->asic_name, "GAUDI"); strscpy(hdev->asic_name, "GAUDI", sizeof(hdev->asic_name));
break; break;
default: default:
dev_err(hdev->dev, "Unrecognized ASIC type %d\n", dev_err(hdev->dev, "Unrecognized ASIC type %d\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment