Commit af200e5a authored by Matt Porter's avatar Matt Porter Committed by Linus Torvalds

[PATCH] ppc32: fix ppc4xx_progress warnings

The patch fixes these warnings by doing two things:
   1) Add the argument to the printk.
   2) Rearrange the ifdef to eliminate the unused variable
      and function warnings.
Signed-off-by: default avatarScott Anderson <sanders@mvista.com>
Signed-off-by: default avatarMatt Porter <mporter@kernel.crashing.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent cbf9589d
...@@ -191,6 +191,7 @@ ppc4xx_calibrate_decr(void) ...@@ -191,6 +191,7 @@ ppc4xx_calibrate_decr(void)
} }
#ifdef CONFIG_SERIAL_TEXT_DEBUG #ifdef CONFIG_SERIAL_TEXT_DEBUG
#ifdef SERIAL_DEBUG_IO_BASE
/* We assume that the UART has already been initialized by the /* We assume that the UART has already been initialized by the
firmware or the boot loader */ firmware or the boot loader */
static void static void
...@@ -204,7 +205,6 @@ static void ...@@ -204,7 +205,6 @@ static void
ppc4xx_progress(char *s, unsigned short hex) ppc4xx_progress(char *s, unsigned short hex)
{ {
char c; char c;
#ifdef SERIAL_DEBUG_IO_BASE
u8 *com_port = (u8 *) SERIAL_DEBUG_IO_BASE; u8 *com_port = (u8 *) SERIAL_DEBUG_IO_BASE;
while ((c = *s++) != '\0') { while ((c = *s++) != '\0') {
...@@ -212,10 +212,14 @@ ppc4xx_progress(char *s, unsigned short hex) ...@@ -212,10 +212,14 @@ ppc4xx_progress(char *s, unsigned short hex)
} }
serial_putc(com_port, '\r'); serial_putc(com_port, '\r');
serial_putc(com_port, '\n'); serial_putc(com_port, '\n');
}
#else #else
printk("%s\r\n"); static void
#endif ppc4xx_progress(char *s, unsigned short hex)
{
printk("%s\r\n", s);
} }
#endif
#endif /* CONFIG_SERIAL_TEXT_DEBUG */ #endif /* CONFIG_SERIAL_TEXT_DEBUG */
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment