Commit b05ae01f authored by Aditya Pakki's avatar Aditya Pakki Committed by Greg Kroah-Hartman

misc/ics932s401: Add a missing check to i2c_smbus_read_word_data

ics932s401_update_device may fail reading in i2c_smbus_read_word_data
due to error in i2c_smbus_xfer. The fix checks the status and defaults
the register to 0.
Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 068ad41e
...@@ -146,6 +146,8 @@ static struct ics932s401_data *ics932s401_update_device(struct device *dev) ...@@ -146,6 +146,8 @@ static struct ics932s401_data *ics932s401_update_device(struct device *dev)
*/ */
for (i = 0; i < NUM_MIRRORED_REGS; i++) { for (i = 0; i < NUM_MIRRORED_REGS; i++) {
temp = i2c_smbus_read_word_data(client, regs_to_copy[i]); temp = i2c_smbus_read_word_data(client, regs_to_copy[i]);
if (temp < 0)
data->regs[regs_to_copy[i]] = 0;
data->regs[regs_to_copy[i]] = temp >> 8; data->regs[regs_to_copy[i]] = temp >> 8;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment