Commit b192541b authored by Luke Browning's avatar Luke Browning Committed by Paul Mackerras

[POWERPC] spufs: spu_find_victim may choose wrong victim

Need to re-check priority after dropping lock.  Otherwise, a
more favored context may be preempted.
Signed-off-by: default avatarLuke Browning <lukebr@linux.vnet.ibm.com>
Signed-off-by: default avatarJeremy Kerr <jk@ozlabs.org>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 91569531
...@@ -626,10 +626,10 @@ static struct spu *find_victim(struct spu_context *ctx) ...@@ -626,10 +626,10 @@ static struct spu *find_victim(struct spu_context *ctx)
} }
spu = victim->spu; spu = victim->spu;
if (!spu) { if (!spu || victim->prio <= ctx->prio) {
/* /*
* This race can happen because we've dropped * This race can happen because we've dropped
* the active list mutex. No a problem, just * the active list mutex. Not a problem, just
* restart the search. * restart the search.
*/ */
mutex_unlock(&victim->state_mutex); mutex_unlock(&victim->state_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment