Commit b19ab4b3 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Jakub Kicinski

ethernet: Fix error handling in xemaclite_of_probe

This node pointer is returned by of_parse_phandle() with refcount
incremented in this function. Calling of_node_put() to avoid the
refcount leak. As the remove function do.

Fixes: 5cdaaa12 ("net: emaclite: adding MDIO and phy lib support")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220308024751.2320-1-linmq006@gmail.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent e5417cbf
...@@ -1183,7 +1183,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) ...@@ -1183,7 +1183,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
if (rc) { if (rc) {
dev_err(dev, dev_err(dev,
"Cannot register network device, aborting\n"); "Cannot register network device, aborting\n");
goto error; goto put_node;
} }
dev_info(dev, dev_info(dev,
...@@ -1191,6 +1191,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev) ...@@ -1191,6 +1191,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
(unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq); (unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq);
return 0; return 0;
put_node:
of_node_put(lp->phy_node);
error: error:
free_netdev(ndev); free_netdev(ndev);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment