Commit b21657ae authored by Mike Christie's avatar Mike Christie Committed by Christoph Hellwig

[PATCH] SCSI: remove extra queue unplug calls

blk_insert_request will do the right thing and either unplug the queue or
call the request_fn, so users of scsi_do_req do not need to call
generic_unplug_device themselves. The attached patch just removes that
call from scsi_lib.c and the sg driver after they do a scsi_do_req.
Signed-off-by: default avatarJames Bottomley <James.Bottomley@SteelEye.com>
parent f020644d
...@@ -255,7 +255,6 @@ void scsi_wait_req(struct scsi_request *sreq, const void *cmnd, void *buffer, ...@@ -255,7 +255,6 @@ void scsi_wait_req(struct scsi_request *sreq, const void *cmnd, void *buffer,
sreq->sr_request->rq_status = RQ_SCSI_BUSY; sreq->sr_request->rq_status = RQ_SCSI_BUSY;
scsi_do_req(sreq, cmnd, buffer, bufflen, scsi_wait_done, scsi_do_req(sreq, cmnd, buffer, bufflen, scsi_wait_done,
timeout, retries); timeout, retries);
generic_unplug_device(sreq->sr_device->request_queue);
wait_for_completion(&wait); wait_for_completion(&wait);
sreq->sr_request->waiting = NULL; sreq->sr_request->waiting = NULL;
if (sreq->sr_request->rq_status != RQ_SCSI_DONE) if (sreq->sr_request->rq_status != RQ_SCSI_DONE)
......
...@@ -718,7 +718,6 @@ sg_common_write(Sg_fd * sfp, Sg_request * srp, ...@@ -718,7 +718,6 @@ sg_common_write(Sg_fd * sfp, Sg_request * srp,
(void *) SRpnt->sr_buffer, hp->dxfer_len, (void *) SRpnt->sr_buffer, hp->dxfer_len,
sg_cmd_done, timeout, SG_DEFAULT_RETRIES); sg_cmd_done, timeout, SG_DEFAULT_RETRIES);
/* dxfer_len overwrites SRpnt->sr_bufflen, hence need for b_malloc_len */ /* dxfer_len overwrites SRpnt->sr_bufflen, hence need for b_malloc_len */
generic_unplug_device(q);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment