Commit b2249129 authored by Julia Lawall's avatar Julia Lawall Committed by Sebastian Reichel

HSI: nokia-modem: fix error return code

Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent c517d838
...@@ -200,6 +200,7 @@ static int nokia_modem_probe(struct device *dev) ...@@ -200,6 +200,7 @@ static int nokia_modem_probe(struct device *dev)
modem->ssi_protocol = hsi_new_client(port, &ssip); modem->ssi_protocol = hsi_new_client(port, &ssip);
if (!modem->ssi_protocol) { if (!modem->ssi_protocol) {
dev_err(dev, "Could not register ssi-protocol device\n"); dev_err(dev, "Could not register ssi-protocol device\n");
err = -ENOMEM;
goto error2; goto error2;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment