Commit b3f46658 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar

cpuidle, ARM/imx6: Push RCU-idle into driver

Doing RCU-idle outside the driver, only to then temporarily enable it
again, at least twice, before going idle is suboptimal.

Notably both cpu_pm_enter() and cpu_cluster_pm_enter() implicity
re-enable RCU.
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Tested-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20230112195539.821714572@infradead.org
parent e038f7b8
...@@ -47,7 +47,9 @@ static int imx6sx_enter_wait(struct cpuidle_device *dev, ...@@ -47,7 +47,9 @@ static int imx6sx_enter_wait(struct cpuidle_device *dev,
cpu_pm_enter(); cpu_pm_enter();
cpu_cluster_pm_enter(); cpu_cluster_pm_enter();
ct_idle_enter();
cpu_suspend(0, imx6sx_idle_finish); cpu_suspend(0, imx6sx_idle_finish);
ct_idle_exit();
cpu_cluster_pm_exit(); cpu_cluster_pm_exit();
cpu_pm_exit(); cpu_pm_exit();
...@@ -87,7 +89,8 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = { ...@@ -87,7 +89,8 @@ static struct cpuidle_driver imx6sx_cpuidle_driver = {
*/ */
.exit_latency = 300, .exit_latency = 300,
.target_residency = 500, .target_residency = 500,
.flags = CPUIDLE_FLAG_TIMER_STOP, .flags = CPUIDLE_FLAG_TIMER_STOP |
CPUIDLE_FLAG_RCU_IDLE,
.enter = imx6sx_enter_wait, .enter = imx6sx_enter_wait,
.name = "LOW-POWER-IDLE", .name = "LOW-POWER-IDLE",
.desc = "ARM power off", .desc = "ARM power off",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment