Commit b4274bcf authored by Brian Gerst's avatar Brian Gerst Committed by Linus Torvalds

[PATCH] Clean up list head usage in sysrq.c

Use list_for_each_entry() instead of open code.
parent 91bdae7c
...@@ -153,7 +153,7 @@ static void go_sync(struct super_block *sb, int remount_flag) ...@@ -153,7 +153,7 @@ static void go_sync(struct super_block *sb, int remount_flag)
if (remount_flag) { /* Remount R/O */ if (remount_flag) { /* Remount R/O */
int ret, flags; int ret, flags;
struct list_head *p; struct file *file;
if (sb->s_flags & MS_RDONLY) { if (sb->s_flags & MS_RDONLY) {
printk("R/O\n"); printk("R/O\n");
...@@ -161,8 +161,7 @@ static void go_sync(struct super_block *sb, int remount_flag) ...@@ -161,8 +161,7 @@ static void go_sync(struct super_block *sb, int remount_flag)
} }
file_list_lock(); file_list_lock();
for (p = sb->s_files.next; p != &sb->s_files; p = p->next) { list_for_each_entry(file, &sb->s_files, f_list) {
struct file *file = list_entry(p, struct file, f_list);
if (file->f_dentry && file_count(file) if (file->f_dentry && file_count(file)
&& S_ISREG(file->f_dentry->d_inode->i_mode)) && S_ISREG(file->f_dentry->d_inode->i_mode))
file->f_mode &= ~2; file->f_mode &= ~2;
...@@ -205,15 +204,11 @@ void do_emergency_sync(void) { ...@@ -205,15 +204,11 @@ void do_emergency_sync(void) {
remount_flag = (emergency_sync_scheduled == EMERG_REMOUNT); remount_flag = (emergency_sync_scheduled == EMERG_REMOUNT);
emergency_sync_scheduled = 0; emergency_sync_scheduled = 0;
for (sb = sb_entry(super_blocks.next); list_for_each_entry(sb, &super_blocks, s_list)
sb != sb_entry(&super_blocks);
sb = sb_entry(sb->s_list.next))
if (sb->s_bdev && is_local_disk(sb->s_bdev)) if (sb->s_bdev && is_local_disk(sb->s_bdev))
go_sync(sb, remount_flag); go_sync(sb, remount_flag);
for (sb = sb_entry(super_blocks.next); list_for_each_entry(sb, &super_blocks, s_list)
sb != sb_entry(&super_blocks);
sb = sb_entry(sb->s_list.next))
if (sb->s_bdev && !is_local_disk(sb->s_bdev)) if (sb->s_bdev && !is_local_disk(sb->s_bdev))
go_sync(sb, remount_flag); go_sync(sb, remount_flag);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment