Commit b7093c10 authored by Adrian Hunter's avatar Adrian Hunter Committed by Ulf Hansson

mmc: tifm_sd: Remove local_irq_{save,restore}() around tifm_sd_transfer_data()

tifm_sd_transfer_data() calls functions that ultimate use kmap_atomic() to
map pages.

A long time ago the kmap_atomic API required a slot to be provided which
risked the possibility that other code might use the same slot at the
same time. Disabling interrupts prevented the possibility of an interrupt
handler doing that. However, that went away with
commit 3e4d3af5 ("mm: stack based kmap_atomic()").

When the second argument to kmap_atomic was removed by commit 482fce99
("mmc: remove the second argument of k[un]map_atomic()"),
local_irq_{save,restore}() should have been removed also.

Remove it now.
Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20221005101951.3165-9-adrian.hunter@intel.comSigned-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 1550217a
...@@ -506,7 +506,6 @@ static void tifm_sd_card_event(struct tifm_dev *sock) ...@@ -506,7 +506,6 @@ static void tifm_sd_card_event(struct tifm_dev *sock)
unsigned int host_status = 0; unsigned int host_status = 0;
int cmd_error = 0; int cmd_error = 0;
struct mmc_command *cmd = NULL; struct mmc_command *cmd = NULL;
unsigned long flags;
spin_lock(&sock->lock); spin_lock(&sock->lock);
host = mmc_priv((struct mmc_host*)tifm_get_drvdata(sock)); host = mmc_priv((struct mmc_host*)tifm_get_drvdata(sock));
...@@ -570,9 +569,7 @@ static void tifm_sd_card_event(struct tifm_dev *sock) ...@@ -570,9 +569,7 @@ static void tifm_sd_card_event(struct tifm_dev *sock)
if (host_status & (TIFM_MMCSD_AE | TIFM_MMCSD_AF if (host_status & (TIFM_MMCSD_AE | TIFM_MMCSD_AF
| TIFM_MMCSD_BRS)) { | TIFM_MMCSD_BRS)) {
local_irq_save(flags);
tifm_sd_transfer_data(host); tifm_sd_transfer_data(host);
local_irq_restore(flags);
host_status &= ~TIFM_MMCSD_AE; host_status &= ~TIFM_MMCSD_AE;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment