Commit b7d002c5 authored by Lubomir Rintel's avatar Lubomir Rintel Committed by Greg Kroah-Hartman

component: do not dereference opaque pointer in debugfs

commit ef9ffc1e upstream.

The match data does not have to be a struct device pointer, and indeed
very often is not. Attempt to treat it as such easily results in a
crash.

For the components that are not registered, we don't know which device
is missing. Once it it is there, we can use the struct component to get
the device and whether it's bound or not.

Fixes: 59e73854 ('component: add debugfs support')
Signed-off-by: default avatarLubomir Rintel <lkundrak@v3.sk>
Cc: stable <stable@vger.kernel.org>
Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Link: https://lore.kernel.org/r/20191118115431.63626-1-lkundrak@v3.skSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ad7a72e8
...@@ -74,11 +74,11 @@ static int component_devices_show(struct seq_file *s, void *data) ...@@ -74,11 +74,11 @@ static int component_devices_show(struct seq_file *s, void *data)
seq_printf(s, "%-40s %20s\n", "device name", "status"); seq_printf(s, "%-40s %20s\n", "device name", "status");
seq_puts(s, "-------------------------------------------------------------\n"); seq_puts(s, "-------------------------------------------------------------\n");
for (i = 0; i < match->num; i++) { for (i = 0; i < match->num; i++) {
struct device *d = (struct device *)match->compare[i].data; struct component *component = match->compare[i].component;
seq_printf(s, "%-40s %20s\n", dev_name(d), seq_printf(s, "%-40s %20s\n",
match->compare[i].component ? component ? dev_name(component->dev) : "(unknown)",
"registered" : "not registered"); component ? (component->bound ? "bound" : "not bound") : "not registered");
} }
mutex_unlock(&component_mutex); mutex_unlock(&component_mutex);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment