Commit b92b36ea authored by Dan Carpenter's avatar Dan Carpenter Committed by Tejun Heo

workqueue: Fix an use after free in init_rescuer()

We need to preserve error code before freeing "rescuer".

Fixes: f187b697 ("workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO.")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent f187b697
...@@ -4197,6 +4197,7 @@ static int wq_clamp_max_active(int max_active, unsigned int flags, ...@@ -4197,6 +4197,7 @@ static int wq_clamp_max_active(int max_active, unsigned int flags,
static int init_rescuer(struct workqueue_struct *wq) static int init_rescuer(struct workqueue_struct *wq)
{ {
struct worker *rescuer; struct worker *rescuer;
int ret;
if (!(wq->flags & WQ_MEM_RECLAIM)) if (!(wq->flags & WQ_MEM_RECLAIM))
return 0; return 0;
...@@ -4208,8 +4209,9 @@ static int init_rescuer(struct workqueue_struct *wq) ...@@ -4208,8 +4209,9 @@ static int init_rescuer(struct workqueue_struct *wq)
rescuer->rescue_wq = wq; rescuer->rescue_wq = wq;
rescuer->task = kthread_create(rescuer_thread, rescuer, "%s", wq->name); rescuer->task = kthread_create(rescuer_thread, rescuer, "%s", wq->name);
if (IS_ERR(rescuer->task)) { if (IS_ERR(rescuer->task)) {
ret = PTR_ERR(rescuer->task);
kfree(rescuer); kfree(rescuer);
return PTR_ERR(rescuer->task); return ret;
} }
wq->rescuer = rescuer; wq->rescuer = rescuer;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment