Commit b9c035aa authored by Jaska Uimonen's avatar Jaska Uimonen Committed by Mark Brown

ASoC: topology: Fix using uninitialized pointer

The original patch changed kcontrol_type to a pointer. In some goto
cases the pointer is assigned into a struct member as uninitialized and
this will cause a runtime error with UBSan even if it isn't a real bug.
So initialize the pointer to NULL.
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: d29d41e2 ("ASoC: topology: Add support for multiple kcontrol types to a widget")
Signed-off-by: default avatarJaska Uimonen <jaska.uimonen@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20210519100713.879958-1-jaska.uimonen@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 60339074
...@@ -1422,7 +1422,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, ...@@ -1422,7 +1422,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
struct snd_soc_dapm_widget template, *widget; struct snd_soc_dapm_widget template, *widget;
struct snd_soc_tplg_ctl_hdr *control_hdr; struct snd_soc_tplg_ctl_hdr *control_hdr;
struct snd_soc_card *card = tplg->comp->card; struct snd_soc_card *card = tplg->comp->card;
unsigned int *kcontrol_type; unsigned int *kcontrol_type = NULL;
struct snd_kcontrol_new *kc; struct snd_kcontrol_new *kc;
int mixer_count = 0; int mixer_count = 0;
int bytes_count = 0; int bytes_count = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment