Commit ba00b190 authored by David Howells's avatar David Howells Committed by Linus Torvalds

afs: Fix vlserver probe RTT handling

In the same spirit as commit ca57f022 ("afs: Fix fileserver probe
RTT handling"), don't rule out using a vlserver just because there
haven't been enough packets yet to calculate a real rtt.  Always set the
server's probe rtt from the estimate provided by rxrpc_kernel_get_srtt,
which is capped at 1 second.

This could lead to EDESTADDRREQ errors when accessing a cell for the
first time, even though the vl servers are known and have responded to a
probe.

Fixes: 1d4adfaf ("rxrpc: Make rxrpc_kernel_get_srtt() indicate validity")
Signed-off-by: default avatarMarc Dionne <marc.dionne@auristor.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
Link: http://lists.infradead.org/pipermail/linux-afs/2023-June/006746.htmlSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4973ca29
...@@ -115,8 +115,8 @@ void afs_vlserver_probe_result(struct afs_call *call) ...@@ -115,8 +115,8 @@ void afs_vlserver_probe_result(struct afs_call *call)
} }
} }
if (rxrpc_kernel_get_srtt(call->net->socket, call->rxcall, &rtt_us) && rxrpc_kernel_get_srtt(call->net->socket, call->rxcall, &rtt_us);
rtt_us < server->probe.rtt) { if (rtt_us < server->probe.rtt) {
server->probe.rtt = rtt_us; server->probe.rtt = rtt_us;
server->rtt = rtt_us; server->rtt = rtt_us;
alist->preferred = index; alist->preferred = index;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment