Commit ba87371d authored by Thomas Graf's avatar Thomas Graf Committed by David S. Miller

[PKT_SCHED]: Make rate estimator work on all platforms.

Fixes the existing rate estimator to compile cleanly on all platforms
and avoids carrying on the variance on platforms with HZ%4 != 0.
Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
Signed-off-by: default avatarJamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 05529e0e
...@@ -66,15 +66,11 @@ ...@@ -66,15 +66,11 @@
* Minimal interval is HZ/4=250msec (it is the greatest common divisor * Minimal interval is HZ/4=250msec (it is the greatest common divisor
for HZ=100 and HZ=1024 8)), maximal interval for HZ=100 and HZ=1024 8)), maximal interval
is (HZ/4)*2^EST_MAX_INTERVAL = 8sec. Shorter intervals is (HZ*2^EST_MAX_INTERVAL)/4 = 8sec. Shorter intervals
are too expensive, longer ones can be implemented are too expensive, longer ones can be implemented
at user level painlessly. at user level painlessly.
*/ */
#if (HZ%4) != 0
#error Bad HZ value.
#endif
#define EST_MAX_INTERVAL 5 #define EST_MAX_INTERVAL 5
struct qdisc_estimator struct qdisc_estimator
...@@ -128,7 +124,7 @@ static void est_timer(unsigned long arg) ...@@ -128,7 +124,7 @@ static void est_timer(unsigned long arg)
spin_unlock(e->stats_lock); spin_unlock(e->stats_lock);
} }
mod_timer(&elist[idx].timer, jiffies + ((HZ/4)<<idx)); mod_timer(&elist[idx].timer, jiffies + ((HZ<<idx)/4));
read_unlock(&est_lock); read_unlock(&est_lock);
} }
...@@ -161,7 +157,7 @@ int qdisc_new_estimator(struct tc_stats *stats, spinlock_t *stats_lock, struct r ...@@ -161,7 +157,7 @@ int qdisc_new_estimator(struct tc_stats *stats, spinlock_t *stats_lock, struct r
if (est->next == NULL) { if (est->next == NULL) {
init_timer(&elist[est->interval].timer); init_timer(&elist[est->interval].timer);
elist[est->interval].timer.data = est->interval; elist[est->interval].timer.data = est->interval;
elist[est->interval].timer.expires = jiffies + ((HZ/4)<<est->interval); elist[est->interval].timer.expires = jiffies + ((HZ<<est->interval)/4);
elist[est->interval].timer.function = est_timer; elist[est->interval].timer.function = est_timer;
add_timer(&elist[est->interval].timer); add_timer(&elist[est->interval].timer);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment